bug(MC-2299): Fix c2a param not tracked for open_url and close actions #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasct
requested review from
CTLalit,
piyush-kukadiya,
Anush-Shand and
nzagorchev
CTLalit
approved these changes
Nov 4, 2024
Anush-Shand
approved these changes
Nov 4, 2024
Anush-Shand
reviewed
Nov 4, 2024
| final String[] parts = actionParts.split("__dl__"); | ||
| String callToAction = formData.getString(Constants.KEY_C2A); | ||
| if (callToAction != null) { | ||
| final String[] parts = callToAction.split("__dl__"); |
There was a problem hiding this comment.
__ dl__ Can be extracted as a constant?
CTLalit
added a commit
that referenced
this pull request
Nov 29, 2024
* bug(MC-2299): Fix c2a param not tracked for open_url and close actions (#681) * refactor(MC-2362): Add parsing of url params on open-url action (#684) * task(MC-2360): Add normalized event and property names evaluation (#685) * task(MC-2360): Add normalized event and property names evaluation * chore(MC-1987): Update HTML template for In-Apps preview (#680) * chore(MC-1987): Update HTML template for In-Apps preview * Add normalized names check to discarded events check (#688) * bug(SDK-4107): Make clevertap instance singleton (#687) - initialises singleton clevertap instance in application class - uses singleton ct instance in whole app * Update preview in-app html template (#690) Applies fix for new lines and special js symbols * Bug/v2/sdk 4183 (#698) * feat(SDK-4183): Event properties normalisation - backend sends normalised event properties, we need to compare on sdk side based on normalised event which client app might fire * feat(SDK-4183): Charged event product props normalisation - normalises product item prop keys * chore(SDK-4183): reformatting * test(SDK-4183): adds test to check normalisation * test(SDK-4183): adds test to check normalisation in non charged events * feat(SDK-4183): changes normalisation to follow LP logic (#700) * feat(SDK-4183): changes normalisation to follow LP logic - makes changes to event names and properties and also to charged event logic - tries exact name match first - tries match with normalised event name - tries match after normalising both event name/property and triggers we get from BE * tests(SDK-4183): adds test cases for nomalisation logic - adds for both charged and normal events. * Release corev7.0.3 (#699) * feat(SDK-4183): updates docs for core SDK release 7.0.3 * feat(SDK-4163): updates the release date - changes title from bug fixes -> new features * feat(SDK-4163): updates the release date in changelog --------- Co-authored-by: Vassil Angelov <[email protected]>
CTLalit
pushed a commit
that referenced
this pull request
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes tracking callToAction if it exists as a parameter to the links opened from the in-apps webview. There is also a frontend fix directly in the in-app HTML, that would use triggerAction instead of opening links.